Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linting subset of files with bin/lint and fix erb_lint deprecation errors #4852

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Dec 13, 2024

Doesn't resolve any issue.

Description

Erb lint was giving some deprecation warning about the name of the file/command, so those were fixed.

Also added the ability to pass along individual files/folders to the bin/lint command, because linting all files takes 30 seconds on my laptop and I am often only changing a few files per branch. (If this change is unwanted, I can remove it and just use an alias on my computer. But I figured it might help others)

Type of change

  • Documentation update
  • Developer experience update

How Has This Been Tested?

Only manually, as these are bash functions.

Screenshots

Note the old deprecation warnings:
image

@cielf cielf requested a review from dorner December 13, 2024 18:39
@dorner dorner merged commit 1fce009 into rubyforgood:main Dec 14, 2024
12 checks passed
Copy link
Contributor

@coalest: Your PR Allow linting subset of files with bin/lint and fix erb_lint deprecation errors is part of today's Human Essentials production release: 2024.12.15.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants