Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #4728 #4734

Conversation

jorgecoutinhobr
Copy link
Contributor

Resolves #4728

Description

  • Prevent deletion of items that are part of a request

Type of change

  • Bug fix

How Has This Been Tested?

  • Add model tests to ensure items cannot be deleted if they are part of a request

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on functional testing. @dorner - do you have any technical comments?

@cielf cielf requested a review from dorner October 23, 2024 17:26
@dorner
Copy link
Collaborator

dorner commented Oct 27, 2024

All good - just waiting for tests to run.

@dorner dorner merged commit 558e28a into rubyforgood:main Oct 27, 2024
11 checks passed
Copy link
Contributor

github-actions bot commented Nov 3, 2024

@jorgecoutinhobr: Your PR Resolves #4728 is part of today's Human Essentials production release: 2024.11.03.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow deletion of items that are part of a request
3 participants