Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #4681 csv export for donation sites #4732

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Resolves #4681 csv export for donation sites #4732

merged 2 commits into from
Oct 27, 2024

Conversation

Nisuha
Copy link
Contributor

@Nisuha Nisuha commented Oct 23, 2024

Resolves #4681

Description

  • changed file name donation_sites.csv to donation_sites_template.csv since this was causing a problem
  • added test for the csv export

@cielf cielf self-requested a review October 23, 2024 17:10
cielf
cielf reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! @dorner Do you have any technical comments?

@cielf cielf requested a review from dorner October 23, 2024 17:11
awwaiid
awwaiid approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and thank you for the additional specs. Will merge tomorrow to go out in the following release.

@awwaiid awwaiid merged commit c11e343 into rubyforgood:main Oct 27, 2024
11 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

@Nisuha: Your PR Resolves #4681 csv export for donation sites is part of today's Human Essentials production release: 2024.11.03.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cielf cielf cielf left review comments

@awwaiid awwaiid awwaiid approved these changes

@dorner dorner Awaiting requested review from dorner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Donation Sites export isn't actually exporting the current donation sites -- just a skeleton.
3 participants
@Nisuha @awwaiid @cielf