Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4672 header alignment #4730

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

inane-pixel
Copy link
Contributor

@inane-pixel inane-pixel commented Oct 22, 2024

Partial #4672

Description

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

@cielf
Copy link
Collaborator

cielf commented Oct 23, 2024

Changed to "Partial" because the issue is about all the views, and this doesn't address all of them.

@cielf
Copy link
Collaborator

cielf commented Oct 23, 2024

Hey @inane-pixel -- this is failing on the lint. You should be able to run erblint --lint-all on your local to catch the problems it is complaining about.

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cielf cielf merged commit c23c8cd into rubyforgood:main Oct 23, 2024
11 checks passed
Copy link
Contributor

@inane-pixel: Your PR 4672 header alignment is part of today's Human Essentials production release: 2024.10.27.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants