-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discarded Storage Location and Inactive Item #4713
Discarded Storage Location and Inactive Item #4713
Conversation
9bed693
to
05996bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lit-poks, you've got an item with an inactive status and a storage location that has an inactive status -- good -- but you missed that they both have to have 0 current inventory. Can you address that, please?
hi @cielf , i made the changes regarding inventory they are 0 for both now. I hope it is what you are looking for. let me know if there are any issues. cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix inventory seeding for storage location from donations
5035ebf
to
44be52b
Compare
Hi @cielf, found the leak, it was from Donations. should be all fixed now. please check. tested it on my end as well. |
@lit-poks: Your PR |
Resolves #4526
Description
Type of change
How Has This Been Tested?
Testing Inactive Item:
Adult Briefs (Large/X-Large)
)Also include inactive items
checkboxTesting Discarded Storage Location
include inactive storage locations
checkboxScreenshots