Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discarded Storage Location and Inactive Item #4713

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

lit-poks
Copy link
Contributor

@lit-poks lit-poks commented Oct 9, 2024

Resolves #4526

Description

  • Added a Storage Location that is discarded in the seed
  • Made atleast one item of an organization inactive

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Testing Inactive Item:

  • Login as [email protected]
  • Go to Inventory > Items and Inventory
  • Go to Items Tab
  • Filter for Item that was marked inactive (in my case Adult Briefs (Large/X-Large))
  • Check if it appears on the list (it doesnt) (first screenshot)
  • Click the Also include inactive items checkbox
  • Check if it appears on the list(second screenshot), it does!

Testing Discarded Storage Location

  • Login as [email protected]
  • Go to Inventory > storage locations
  • At first only 2 storage location appears (third screenshot)
  • Click the include inactive storage locations checkbox
  • Check if it appears on the list(fourth screenshot), it does!

Screenshots

image image image image

@lit-poks lit-poks marked this pull request as ready for review October 9, 2024 16:40
@lit-poks lit-poks force-pushed the seed/inactive-location-and-items branch from 9bed693 to 05996bf Compare October 9, 2024 16:46
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lit-poks, you've got an item with an inactive status and a storage location that has an inactive status -- good -- but you missed that they both have to have 0 current inventory. Can you address that, please?

@lit-poks
Copy link
Contributor Author

hi @cielf , i made the changes regarding inventory they are 0 for both now. I hope it is what you are looking for.

let me know if there are any issues. cheers

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The item looks alright. I'm still seeing inventory for the inactive storage location, though.

I think what's going on is that various things that add items in the seed (such as donations, purchases, adjustments, transfers) might not be limiting themselves to active storage locations.

Screenshot 2024-10-11 at 2 23 11 PM

Fix inventory seeding for storage location from donations
@lit-poks lit-poks force-pushed the seed/inactive-location-and-items branch from 5035ebf to 44be52b Compare October 13, 2024 07:37
@lit-poks
Copy link
Contributor Author

Hi @cielf,

found the leak, it was from Donations. should be all fixed now. please check. tested it on my end as well.

image

@cielf cielf merged commit 140bbfe into rubyforgood:main Oct 14, 2024
11 checks passed
Copy link
Contributor

@lit-poks: Your PR Discarded Storage Location and Inactive Item is part of today's Human Essentials production release: 2024.10.20.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inactive storage locations and items to the seed
2 participants