Refactor Annual Survey report: #4711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change 'Diaper Acquisition' to 'Diapers' - Rename service from AcquisitionReportService to DiaperReportService
|
This PR addresses issue #4686 by: Changing 'Diaper Acquisition' to 'Diapers' in the Annual Survey report. |
|
Hi @princekumarg12 -- There is already a PR out for this. Assuming it works, we'll be going with the first one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update includes:
Resolves #4686
Changed 'Diaper Acquisition' to 'Diapers' in the Annual Survey report.
Renamed AcquisitionReportService to DiaperReportService for clarity.
Motivation:
To improve clarity and consistency in terminology.
Type of change
Bug fix (non-breaking change)
How Has This Been Tested?
Tested by signing in as [email protected], navigating to Reports -> Annual Survey, and recalculating the report. All tests passed with bundle exec rake.
Screenshots
