Remove organization from superuser edit/index of users #4453
Conversation
app/views/admin/users/new.html.erb
Outdated
| <%= f.input :organization_id, label: "Organization", wrapper: :input_group, required: true, autofocus: true do %> | ||
| <span class="input-group-text"><%= fa_icon "building" %></span> | ||
| <%= f.input_field :organization_id, collection: @organizations, class: "form-control" %> | ||
| <% end %> |
There was a problem hiding this comment.
The ticket suggested not making changes to New, just Edit.
There was a problem hiding this comment.
This is true. I'm trying to find the issue that past CL failed to link to in this issue. (i.e. why it is a separate thing) (it's still in our backlog, but part of a larger being able to add more types of users -- including superadmins).
New doesn't currently have the role and resource part of the form -- removing the organization without other changes will simply break it.
|
@cancelei are you still planning to finish this up? |
|
@dorner Since this PR has been kind of abandoned, I went ahead and tried to wrap it up. It's now ready for review. |
coalest
changed the title
|
This looks good to me functionally. I have added making the new users add a role instead of the organization to the project's copious inbox. |
|
@dorner Can you take a final look at this? |
|
@cancelei: Your PR |
… admin users list view
Resolves #4296
Description
Type of change
How Has This Been Tested?
Screenshots