4423 format account request org websites #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cielf
previously requested changes
Jun 5, 2024
app/models/account_request.rb
Outdated
| @@ -21,6 +21,7 @@ class AccountRequest < ApplicationRecord | |||
| validates :email, presence: true, uniqueness: true | |||
| validates :request_details, presence: true, length: { minimum: 50 } | |||
| validates :email, format: { with: URI::MailTo::EMAIL_REGEXP } | |||
| validates :organization_website, format: { with: URI::DEFAULT_PARSER.make_regexp, message: "it should look like 'http://www.example.com'" }, allow_blank: true | |||
There was a problem hiding this comment.
Please remove the "it" at the beginning of the message. Thanks.
There was a problem hiding this comment.
Removed the "it" from the message
dorner
requested changes
Jun 7, 2024
app/models/account_request.rb
Outdated
| @@ -21,6 +21,7 @@ class AccountRequest < ApplicationRecord | |||
| validates :email, presence: true, uniqueness: true | |||
| validates :request_details, presence: true, length: { minimum: 50 } | |||
| validates :email, format: { with: URI::MailTo::EMAIL_REGEXP } | |||
| validates :organization_website, format: { with: URI::DEFAULT_PARSER.make_regexp, message: "should look like 'http://www.example.com'" }, allow_blank: true | |||
There was a problem hiding this comment.
The default should be https, not http. Pretty much every website in existence is on httpsnow.
| @@ -75,7 +75,7 @@ | |||
| </div> | |||
|
|
|||
| <div class="form-inputs"> | |||
| <%= f.input :organization_website %> | |||
| <%= f.input :organization_website, placeholder: "http://www.example.com" %> | |||
Good point. I'll change that up! |
Majority of websites are now https
|
Updated 👍🏽 |
dorner
approved these changes
Jun 14, 2024
|
Thanks! |
|
Yeah, thank y'all as well! |
|
@Gabe-Torres: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4423
Description
This pr implements adding validation for the
organization_websiteattribute within theaccount_requestmodel and enforces a URL format that will reduce the account acceptance process for admins. It also adds an example placeholder in the account request form to reduce confusion.Type of change
How Has This Been Tested?
organization_websitesattribute validation is now being tested within theaccount_requestmodel spec and enforces valid URL formats and will not validatewww.example.comformatsit { should allow_value(Faker::Internet.url).for(:organization_website) }it { should_not allow_value("www.example.com").for(:organization_website) }Screenshots
Before
After