Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up incorrect request statuses that have a distribution [#4275] #4370

Merged
merged 1 commit into from
May 22, 2024

Conversation

awwaiid
Copy link
Collaborator

@awwaiid awwaiid commented May 19, 2024

Validated by pulling down a production snapshot and running locally.

There are only 6 records that are fixed by this data cleanup, affecting helping_moms, sweetcheeks, and franciscan.

@awwaiid awwaiid requested a review from cielf May 19, 2024 20:32
@cielf
Copy link
Collaborator

cielf commented May 19, 2024

When I look at prod, I see 7 that should be fixed (status 1 and have a distribution ID ). What am I missing?

@awwaiid
Copy link
Collaborator Author

awwaiid commented May 20, 2024

@cielf my prod snapshot was old, I just now ran it and also got 7 rather than 6. There is a new one from 2024-04-15. So .... I guess that means this can still happen?

@cielf
Copy link
Collaborator

cielf commented May 20, 2024

Yeah. Let's make that investigating that a separate issue. It's uncommon, but there's some way to make it happen!

Noting that we'll also want to send a communication to the 3 affected banks.

@cielf
Copy link
Collaborator

cielf commented May 21, 2024

The issue with setup is blocking me from doing a proper check on this. It's high on my list, though.

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cielf cielf merged commit 460b66d into main May 22, 2024
38 checks passed
@cielf cielf deleted the started-finished-requests branch May 22, 2024 16:38
Copy link
Contributor

@awwaiid: Your PR Clean up incorrect request statuses that have a distribution [#4275] is part of today's Human Essentials production release: 2024.05.26.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants