Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove reliance on seeded db data (services 2) #4332

Merged
merged 3 commits into from
May 10, 2024

Conversation

elasticspoon
Copy link
Collaborator

@elasticspoon elasticspoon commented May 5, 2024

Related to #4199

Remaining service specs.

Type of change

  • Refactor

How Has This Been Tested?

Passes current suite

@elasticspoon elasticspoon force-pushed the remove-spec-seeding-services-2 branch from aac88a7 to dddf436 Compare May 5, 2024 17:59
@elasticspoon elasticspoon force-pushed the remove-spec-seeding-services-2 branch 2 times, most recently from 1f945cd to 7ac94e4 Compare May 5, 2024 18:14
@elasticspoon elasticspoon force-pushed the remove-spec-seeding-services-2 branch from 7ac94e4 to 381ba0e Compare May 5, 2024 18:18
@elasticspoon elasticspoon changed the title (WIP) Remove spec seeding services 2 refactor: remove reliance on seeded db data (services 2) May 5, 2024
@elasticspoon elasticspoon mentioned this pull request May 5, 2024
21 tasks
@elasticspoon elasticspoon marked this pull request as ready for review May 5, 2024 18:32
@elasticspoon elasticspoon requested a review from dorner May 5, 2024 18:32
@elasticspoon elasticspoon force-pushed the remove-spec-seeding-services-2 branch from ed4eca8 to b89788d Compare May 7, 2024 01:03
@elasticspoon elasticspoon requested a review from dorner May 7, 2024 01:19
@dorner dorner merged commit 36de864 into rubyforgood:main May 10, 2024
19 checks passed
@elasticspoon elasticspoon deleted the remove-spec-seeding-services-2 branch May 10, 2024 00:31
Copy link
Contributor

@elasticspoon: Your PR refactor: remove reliance on seeded db data (services 2) is part of today's Human Essentials production release: 2024.05.12.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants