Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump knapsack_pro from 6.0.4 to 7.0.0 #4140

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 26, 2024

Bumps knapsack_pro from 6.0.4 to 7.0.0.

Changelog

Sourced from knapsack_pro's changelog.

7.0.0

  • (breaking change) RSpec in Queue Mode:

    • The default for KNAPSACK_PRO_LOG_LEVEL is info instead of debug.

    • The RSpec before(:suite) and after(:suite) hooks changed:

      Before: The before(:suite) and after(:suite) hooks were executed multiple times. Each time for a batch of tests fetched from Knapsack Pro Queue API.

      After: The before(:suite) and after(:suite) hooks are executed only once: before(:suite) is executed before starting tests, after(:suite) is executed after all tests are completed. (It is what you would expect from RSpec).

    • The KnapsackPro::Hooks::Queue.after_queue hook change:

      Before: The KnapsackPro::Hooks::Queue.after_queue hook is executed outside of the after(:suite) hook.

      After: The KnapsackPro::Hooks::Queue.after_queue hook is executed inside of the after(:suite) hook.

  • Recommended RSpec changes in your project:

    • Remove the following code if you use Queue Mode and the rspec_junit_formatter gem to generate JUnit XML or JSON reports:

      # REMOVE THE FOLLOWING CODE
      spec_helper.rb or rails_helper.rb
      TMP_REPORT = "tmp/rspec_#{ENV['KNAPSACK_PRO_CI_NODE_INDEX']}.xml"
      FINAL_REPORT = "tmp/final_rspec_#{ENV['KNAPSACK_PRO_CI_NODE_INDEX']}.xml"
      KnapsackPro::Hooks::Queue.after_subset_queue do |queue_id, subset_queue_id|
      if File.exist?(TMP_REPORT)
      FileUtils.mv(TMP_REPORT, FINAL_REPORT)
      end
      end

      Learn more about using Knapsack Pro with RSpec formatters and using Knapsack Pro with CircleCI in the docs.

    • Replace the following code if you are using Queue Mode and the percy-capybara gem on a version older than 4:

      Before:

      KnapsackPro::Hooks::Queue.before_queue { |queue_id| Percy::Capybara.initialize_build }
      KnapsackPro::Hooks::Queue.after_queue { |queue_id| Percy::Capybara.finalize_build }

      After:

... (truncated)

Commits
  • f7936cf Bump version 7.0.0
  • cae6e45 update(C): Use Ruby 3.3 on CI for unit tests
  • d3568c5 Stop calling RSpec::Core::Runner#run multiple times in Queue Mode (#237)
  • c8baeee ci: test also ruby 3.3
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 6.0.4 to 7.0.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md)
- [Commits](KnapsackPro/knapsack_pro-ruby@v6.0.4...v7.0.0)

---
updated-dependencies:
- dependency-name: knapsack_pro
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 26, 2024
@dorner dorner merged commit 07f3879 into main Feb 26, 2024
20 checks passed
@dorner dorner deleted the dependabot/bundler/knapsack_pro-7.0.0 branch February 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant