fix: select fields on request pages (#4069 partial) #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses part of issue rubyforgood#4069: After a request bad request is submitted the select input disappears and turns into a text input. This was caused by formatted_requestable_items not being set. Refactors setting @formatted_requestable_items to a private method call. Unifies all the behavior of setting requestable items. Adds additional tests to ensure select fields have correct values. feat: adds TODOs
elasticspoon
force-pushed
the
4069-individual-requests-issue
branch
from
841d220 to
65357e2
Compare
elasticspoon
changed the title
dorner
requested changes
Feb 13, 2024
Renames formatted_requestable_items to requestable_items Moves formatting and sorting to service object Adds tests for service object Removes method with side effect in favor of direct call to service object to set @requestable_items refactor: removes unneeded code Removes testing of service object from system spec
elasticspoon
force-pushed
the
4069-individual-requests-issue
branch
from
6b9a10a to
57fb8a6
Compare
elasticspoon
commented
Feb 13, 2024
dorner
requested changes
Feb 14, 2024
Conflicts:
app/views/partners/requests/new.html.erb
Previously tests were simply re-stating the original code. Now specific items are set on the org and partner The tests then check in the service object return a correct subset of those items.
elasticspoon
force-pushed
the
4069-individual-requests-issue
branch
from
ab9c638 to
521d856
Compare
dorner
requested changes
Feb 16, 2024
Tried to make it a bit more clear what is getting set up in the service.
elasticspoon
commented
Feb 19, 2024
fix: set name manually fix: change bad request test Adds a test to make sure incorrect inputs do not get cleared on submission.
elasticspoon
force-pushed
the
4069-individual-requests-issue
branch
from
26610a0 to
833b199
Compare
dorner
requested changes
Feb 20, 2024
dorner
approved these changes
Feb 25, 2024
|
@elasticspoon , @dorner The field is a drop-down again! Yay! Alas, on manually testing this on staging before we push to production, I found that the content is still disappearing. This is definitely a step in the right direction, though, so I'm going to recommend we push it to production. |
|
That fix got moved to another PR #4142 that has not yet been merged. Unless additional content stopped getting preserved? It should only be values on individual request pages that don't get preserved. |
|
I've only seen the values (at least all the items, whether or not complete) on the individual request pages not getting preserved. So, ok - it's on another PR. |
|
@elasticspoon: Your PR |
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #4069 has two parts:
This PR (so far) fixes part 2:
After a request bad request is submitted the select input disappears and turns into a text input:
This was caused by formatted_requestable_items not being set. PR set value.
Additionally, the select field has different values on a new request vs failed request:
Refactors setting @formatted_requestable_items to a private method call. Unifies all the behavior of setting requestable items.
Part 1 is not addressed. I have been unable to replicate locally.
Type of change
How Has This Been Tested?
Added systems tests to test the select inputs.