Upgrade to Ruby 3.2 #3950
Upgrade to Ruby 3.2 #3950
Conversation
| @@ -5,8 +5,6 @@ git_source(:github) do |repo_name| | |||
| "https://github.com/#{repo_name}.git" | |||
| end | |||
|
|
|||
| ruby "3.1.2" | |||
There was a problem hiding this comment.
Is this deleted by mistake? bundler needs to know the ruby version.
Is there a hook within the project for the bundler to read from .ruby-version?
There was a problem hiding this comment.
No, it's not a mistake - Cloud66 [explicitly says to delete this](https://help.cloud66.com/docs/build-and-config/managing-and-upgrading-ruby-versions#how-we-determine-the-version-to-use). It's not needed within the Gemfile. If you're using a Ruby version manager like RVM or asdf, it'll use .ruby-version. We control the version on CI with our GitHub Actions file, and Cloud66 uses the manifest file.
There was a problem hiding this comment.
Gotcha! And @dorner have you noticed any issue with this in local development? ( I like the code when it is more explicit than implicit. ) Cloud66 checks the version in manifest file first. So we can have it in both the places to satisfy local dev & deployment. Thoughts?
There was a problem hiding this comment.
Nope, haven't noticed any issue. I left in .ruby-version which would power local dev.
|
@dorner: Your PR |
No description provided.