Adding 5T/6T Pull-ups to seed, plus migration for prod. #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
approved these changes
Nov 17, 2023
|
Looks good! |
|
@cielf: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the 5T / 6T size of pull ups to the base items. This is a reasonable extension of the preexisting selection.
-- migration so it gets added to prod
-- addition to base _items.json so it will be present in seeded data.
Migration is required because the superuser's base item form is missing the category, which is needed for some reports.
Type of change
How Has This Been Tested?
Visual confirmation through the drop down in the Inventory|Items & Inventory|New Item