-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move purchase from dashboard to standalone report [#3736] #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rae-stanton
force-pushed
the
3736-actual-move-purchase-frm-dash
branch
from
July 29, 2023 20:35
4fd66dd
to
5fc4004
Compare
awwaiid
changed the title
3736 actual move purchase frm dash
Move purchase from dashboard to standalone report [#3736]
Jul 30, 2023
rae-stanton
force-pushed
the
3736-actual-move-purchase-frm-dash
branch
from
July 30, 2023 13:15
5fc4004
to
fbe290f
Compare
Fixes #3736 These changes include: Needed to change the dashboard to not contain any information about the purchases summary - this has now been moved to the new purchases summary page within the nav bar under `reporting and auditing`. Filtering has also been added to said page, and filter partials and the card have been added to a shared area for ease of access and consistency. Page tests added for new content.
rae-stanton
force-pushed
the
3736-actual-move-purchase-frm-dash
branch
from
July 30, 2023 13:30
0c9bda0
to
94f12c0
Compare
awwaiid
commented
Jul 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor requests while I fire it up for a local peek
fixed weird spacing issue, removed duplicate file
awwaiid
commented
Jul 30, 2023
Fixed small issue in render - duplicate partial now removed
@awwaiid: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #3736 - removed the purchases summary from user dashboard area into the Reporting & Auditing section. Added new page tests for the summary & simple logged in/out test coverage.