Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move purchase from dashboard to standalone report [#3736] #3792

Merged
merged 3 commits into from
Jul 30, 2023

Conversation

awwaiid
Copy link
Collaborator

@awwaiid awwaiid commented Jul 29, 2023

Resolves issue #3736 - removed the purchases summary from user dashboard area into the Reporting & Auditing section. Added new page tests for the summary & simple logged in/out test coverage.

@rae-stanton rae-stanton force-pushed the 3736-actual-move-purchase-frm-dash branch from 4fd66dd to 5fc4004 Compare July 29, 2023 20:35
@scooter-dangle scooter-dangle added the Ruby for Good 2023 DC Created for Ruby for Good 2023 DC label Jul 29, 2023
@awwaiid awwaiid changed the title 3736 actual move purchase frm dash Move purchase from dashboard to standalone report [#3736] Jul 30, 2023
@rae-stanton rae-stanton force-pushed the 3736-actual-move-purchase-frm-dash branch from 5fc4004 to fbe290f Compare July 30, 2023 13:15
Fixes #3736
These changes include:
Needed to change the dashboard to not contain any information about the purchases summary - this has now been moved to the new purchases summary page within the nav bar under `reporting and auditing`. Filtering has also been added to said page, and filter partials and the card have been added to a shared area for ease of access and consistency. Page tests added for new content.
@rae-stanton rae-stanton force-pushed the 3736-actual-move-purchase-frm-dash branch from 0c9bda0 to 94f12c0 Compare July 30, 2023 13:30
@rae-stanton rae-stanton marked this pull request as ready for review July 30, 2023 13:36
Copy link
Collaborator Author

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requests while I fire it up for a local peek

app/views/purchases_summary/index.html.erb Outdated Show resolved Hide resolved
app/views/purchases_summary/index.html.orginal.erb Outdated Show resolved Hide resolved
app/views/dashboard/index.html.erb Show resolved Hide resolved
@awwaiid awwaiid requested a review from scooter-dangle July 30, 2023 13:48
fixed weird spacing issue, removed duplicate file
Fixed small issue in render - duplicate partial now removed
@awwaiid awwaiid merged commit 77fda90 into dashboard Jul 30, 2023
@awwaiid awwaiid deleted the 3736-actual-move-purchase-frm-dash branch July 30, 2023 14:04
@awwaiid awwaiid added this to the Dashboard Update milestone Nov 12, 2023
Copy link
Contributor

@awwaiid: Your PR Move purchase from dashboard to standalone report [#3736] is part of today's Human Essentials production release: 2024.05.26.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants