Dashboard Refactor - Itemized Donations [#3733] #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
changed the title
…ed-donations-3733 Conflicts: app/views/layouts/_lte_sidebar.html.erb
Not sure how these got into this branch specifically, but ok.
Comment on lines
2
to
5
| id ||= nil | ||
| title ||= nil | ||
| subtitle ||= nil | ||
| footer ||= nil |
There was a problem hiding this comment.
Scott's dumb lack of Rails knowledge…what falsey value are these defaulting to such that nil is better? false, right? 🤔
There was a problem hiding this comment.
I think I grabbed these from another branch -- this partial can be cleaned / simplified a bit, but I'd like to do it elsewhere.
|
Is this a WIP or is it R4R? |
|
@scooter-dangle sorry -- ready for review / merge now; I updated the description with some testing notes. |
|
(merge into |
…ed-donations-3733 Conflicts: app/views/dashboard/index.html.erb app/views/layouts/_lte_sidebar.html.erb app/views/shared/_card.html.erb
|
@awwaiid: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3733
Plucks the Itemized Donations off of the main dashboard and stashes it away on its own page.
Tested locally and with a new system spec! Manually verified date range filters.