1181 upgrade rails 6

[ozydingo]

Checklist:

• I have performed a self-review of my own code,
• I have commented my code, particularly in hard-to-understand areas,
• I have made corresponding changes to the documentation,
• I have added tests that prove my fix is effective or that my feature works,
• New and existing unit tests pass locally with my changes ("bundle exec rake"),
• Title include "WIP" if work is in progress.

Resolves #1181

Description

Start with rails app:upgrade. However, this inflicts many changes, most of which are unnecessary or clobber needed app functionality or setup. So I went through all changes and discarded such changes, confirming the app still runs and tests pass.

I also discarded most formatting / text / commenting changes to keep the PR easier on the eyes. For a review of the changes that are caused by rails app:upgrade, reference #1204

Upgrade rails and other gems that had broken dependencies or behaviors. This include rspec, which had to be upgraded to >=4 (currently in beta, but due to be released soon. See rspec/rspec-rails#2086)

I reviewed https://edgeguides.rubyonrails.org/6_0_release_notes.html for other breaking changes and search the app for any occurrences. Only relevant item (caught by a test) was dealing with content_type on attachments (see organziation.rb)

Labelled WIP because I think it would be wise to manually test various app setups and features in addition to relying on rspec tests, and I am not fluent enough in this app to do so with confidence.

Type of change

• Software upgrade

How Has This Been Tested?

Tests pass. Poked around app. Should poke around more.

[auto-comment]

Thank you for your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
Best,
@diaper-team

[armahillo]

That error comes up in the app currently -- you just have to re-run the command. I'm not sure why it's happening and agree that it probably shouldnt, but this isn't a Rails 6 specific issue.

[ozydingo]

I'm getting it consistently on my machine, and I don't get it on master. Maybe it's a bit of both, sprinkled with a little OS X funtimes?

[armahillo]

ha -- That's possible.

This issue looks related: rails/rails#37407

It might be an upstream problem. What's the consequences of leaving this commented for now? We just have to do RAILS_ENV=test bundle exec rails db:migrate after running regular migrations?

[armahillo]

Agreed that we should test this manually. We might want to wait until after the conference to actually push the upgrade out; we're doing a live Demo on Thursday afternoon.

[armahillo]

also -- looks like the only reason the build fails is because of a rubocop "useless assignment" thing related to logo = nil. don't sweat that too much right now. We need to do some manual testing before merging this and can sort it out later.

thanks for tackling this! I appreciate preserving a lot of the existing config stuff we have built. I wish the Rails upgrader would be a bit more judicious about applying those changes :/

[ozydingo]

also -- looks like the only reason the build fails is because of a rubocop "useless assignment" thing related to logo = nil. don't sweat that too much right now. We need to do some manual testing before merging this and can sort it out later.

thanks for tackling this! I appreciate preserving a lot of the existing config stuff we have built. I wish the Rails upgrader would be a bit more judicious about applying those changes :/

D'oh -- that's because it should have been self.logo = nil to clear the attribute when invalid. As written it just uselessly assigned a local var. Fix pushed.

[armahillo]

I'm good with this, but I'd like the input from @seanmarcia and @mdworken first before we merge it. (Note the issue above with the maintain_test_schema! comment)