Update to Rails 6 (WIP) #1306
Closed
Update to Rails 6 (WIP) #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s task that either clobbered app-specific setup or were unecessary comments or formatting changes.
|
|
|
Closing -- multiple tests now failing (108 failures) after actually upgrading gems (not just running |
|
Repoened: most failures were due to an ActionView change that break rspec <4. Upgraded to rspec4.0.0.beta3 to fix; this decision should be weighted against the need to upgrade to Rails 6. Comment from rspec folks is that 4 will be released soon. See rspec/rspec-rails#2086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Resolves #1181
Description
Start with
rails app:upgrade. However, this inflicts many changes, most of which are unnecessary or clobber needed app functionality or setup. So I went through all changes and discarded such changes, confirming the app still runs and tests pass.I reviewed https://edgeguides.rubyonrails.org/6_0_release_notes.html for breaking changes and search the app for any occurrences; there were none.
I also discarded most formatting / text / commenting changes to keep the PR easier on the eyes.
For a review of the changes that are caused by
rails app:upgrade, reference #1204Labelled WIP because I think it would be wise to manually test various app setups and features in addition to relying on rspec tests, and I am not fluent enough in this app to do so with confidence.
I attempted to remove action_text, which is now included in Rails, but ran into issues with the action_text file not being included, so punted on that for now.
Type of change
How Has This Been Tested?
Tests pass. Poked around app. Should poke around more.