Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset password and invitation expiry #4773

Closed
2 tasks
cielf opened this issue Nov 10, 2024 · 4 comments · Fixed by #4796
Closed
2 tasks

Reset password and invitation expiry #4773

cielf opened this issue Nov 10, 2024 · 4 comments · Fixed by #4796

Comments

@cielf
Copy link
Collaborator

cielf commented Nov 10, 2024

Summary

Invitations should expire in two weeks, password resets in 6 hours Make that happen, and make the text in the associated emails reflect that.

Why?

Right now we are not telling the truth in the emails.

Details

Invitations are sent out when:

  • the bank invites a partner
  • the superadmin approves a bank
  • a bank admin adds a user
  • a partner adds a user
  • a bank user adds a partner user

It appears that these currently do not expire, and they should expire in two weeks.

Password resets expire in 6 hours instead.

The emails sent out in each of these cases should reflect the timeframe for expiry.

Criteria for completion

  • behaviour as described above
  • automated tests to support that behaviour
@pepetorres1998
Copy link
Contributor

Can I take this issue?

@cielf
Copy link
Collaborator Author

cielf commented Nov 11, 2024

Please do

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Nov 11, 2024
@pepetorres1998
Copy link
Contributor

image

This is how it is showing right now. The DateTime is showing in UTC. Should I change it to a different message or use a different time zone? I was thinking of changing the timezone to the user's timezone, but I don't think we manage that data.

@cielf
Copy link
Collaborator Author

cielf commented Nov 12, 2024

Let's make it "This invitation will expire at [Date and Time] GMT or if a new password reset is triggered. "

GMT is equivalent to UTC for purposes of communicating with the users, and they are more likely to know it.

cielf added a commit that referenced this issue Nov 29, 2024
…invitation-expiry

Resolves #4773: Reset password and invitation expiry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants