Fix the issue where only one error is displayed, even when multiple errors are present. #4911
Conversation
nozomirin
force-pushed
the
4613-fix-multiple-errors-but-only-show-one-on-distribution
branch
4 times, most recently
from
cc3e80c to
e7d563d
Compare
…rrors are present.
nozomirin
force-pushed
the
4613-fix-multiple-errors-but-only-show-one-on-distribution
branch
from
e7d563d to
6f80c97
Compare
There was a problem hiding this comment.
Hey @nozomrin -- Thanks for this!
The multiple errors part works well, but you've missed this part of the issue: "The number in brackets after the item (which is the inventory level for that item/storage location) has disappeared -- it should still be there."
Please address.
Sorry, I missed that earlier. The issue has been fixed; please check it. |
app/events/inventory_error.rb
Outdated
| super(message) | ||
| self.item_id = item_id | ||
| self.storage_location_id = storage_location_id | ||
| def initialize(message) |
There was a problem hiding this comment.
You can probably just remove this definition entirely since it does nothing but call super.
| @@ -0,0 +1,14 @@ | |||
| import { Controller} from "@hotwired/stimulus" | |||
There was a problem hiding this comment.
In general Stimulus controllers should be generic. In this case, the controller is just triggering a change event on load. Can we rename this to reflect that?
There was a problem hiding this comment.
Having said that - what does this have to do with the goal of the PR?
There was a problem hiding this comment.
In general Stimulus controllers should be generic. In this case, the controller is just triggering a change event on load. Can we rename this to reflect that?
sure.
Having said that - what does this have to do with the goal of the PR?
It is mentioned in the issue.
There was a problem hiding this comment.
Can you point me to where? I don't see anything related to the frontend.
There was a problem hiding this comment.
|
@nozomirin: Your PR |
Resolves #4613
Description
InventoryActionErrorInventoryErroraggregateInventoryActionErrorsType of change
How Has This Been Tested?
bundle exec rspec spec/events/inventory_aggregate_spec.rbScreenshots