Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Protect against mixed units during partner placing request #4579

Open
2 tasks done
awwaiid opened this issue Aug 4, 2024 · 6 comments
Open
2 tasks done

[BUG]: Protect against mixed units during partner placing request #4579

awwaiid opened this issue Aug 4, 2024 · 6 comments
Assignees
@awwaiid
Labels
🐞 Bug
Milestone
Request Units (Pa...

Comments

@awwaiid
Copy link
Collaborator

awwaiid commented Aug 4, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In the Units-Beta, if I log in as partner and place a request with the same item but differing units, the qty is merged and only one of the units is kept.

Expected Behavior

It should error when there are mixed units trying to be merged.

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

Criteria for Completion

No response

Anything else?

No response

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Ruby for Good community
@awwaiid awwaiid added this to the Request Units (Packs) milestone Aug 4, 2024
@awwaiid awwaiid self-assigned this Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Automatically unassigned after 7 days of inactivity.

@github-actions github-actions bot removed the stale label Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@github-actions github-actions bot removed the stale label Nov 15, 2024
awwaiid added a commit that referenced this issue Dec 8, 2024
@awwaiid
Ensure unique units are used when creating a request [#4579]
5398a8d
@awwaiid awwaiid mentioned this issue Dec 8, 2024
Open
awwaiid added a commit that referenced this issue Dec 8, 2024
@awwaiid
Clean out some lint [#4579]
bfe4512
awwaiid added a commit that referenced this issue Dec 8, 2024
@awwaiid
Update spec wording expectation [#4579]
80d5f4b
awwaiid added a commit that referenced this issue Dec 8, 2024
@awwaiid
Handle items out of order intermittent [#4579]
57bbefb
@github-actions GitHub Actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Dec 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf cielf removed the stale label Dec 23, 2024
awwaiid added a commit that referenced this issue Jan 5, 2025
@awwaiid
Unify call and initialize_only to use same logic [#4579]
b9042a7
awwaiid added a commit that referenced this issue Jan 5, 2025
@awwaiid
Fix create service to make in-memory request even if invalid
824e97f 
Errors are then reported up to the UI but not saved to the database;
this is what the controller and rails forms expects.

[#4579]
awwaiid added a commit that referenced this issue Jan 5, 2025
@awwaiid
Fix re-editing of request units in dynamic JS [#4579]
f99a533
awwaiid added a commit that referenced this issue Jan 5, 2025
@awwaiid
Sate Rubocop! [#4579]
9c7bf05
awwaiid added a commit that referenced this issue Jan 5, 2025
@awwaiid
Update family and individual request validation to match create [#4579]
a622b15
awwaiid added a commit that referenced this issue Jan 6, 2025
@awwaiid
Only include request_unit on request_items when specified [#4579]
469565d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awwaiid awwaiid

Labels
🐞 Bug
Projects
None yet
Milestone
Request Units (Packs)
Development

No branches or pull requests
2 participants
@awwaiid @cielf