-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PACKS] #3 Allowing the selection of custom request units in partner request #4398
Comments
I will claim this. |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
This issue is available for contribution. There is a draft-PR (thank you @patelkrunal31) at #4420 with an experiment toward a dependent-dropdown; you may build on top of that or be inspired by it as you like! |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Summary
Allow the selection of custom request units in partner request
Why
This is step #3 of adding the ability to specify "packs" versus "individual" for requests
Details
When an item is selected that has request choice units, the units drop down will appear. It will contain the reporting unit and the additional units selected. The units will be pluralized.
If the item selected has no request choice units, the units drop down will not appear.
If the item selected has custom units, the units must be selected.
Disallow selecting multiple different unit selections on the same item within the same request. (Example -- we would disallow requesting 15 Adult Briefs (Large XL) units and 3 Adult Briefs (Large XL) packs within the same request. The error message in this case should be "You may only request one unit level per item -- please consolidate: Adult Briefs (Large XL)")
Please note that the seed has data in it that does not pass the above condition -- we'll need to address that too!
N.B.
All of the changes for PACKS must be implemented behind a flipper flag "enable_packs"
1/ Flipper works by enabling or disabling a tag (for the PACKS issues, that is enable_packs)
2/ Here is a code snippet illustrating how to use it in your code, with enable_packs as the example tag:
if Flipper.enabled?(:enable_packs)
// do the thing we are guarding with the tag
end
3/ How to check out if it works manually (with the example tag: enable_packs ):
You have to enable the flipper tag on your localhost (note - the tag is stored in your db, so if you reset your db you have to do it again)
localhost:3000/flipper
userid: admin
password: password
Sign In
Click: Add feature
enable_packs
Click: Add feature
Click: Fully enable
To set it back (to check that your nifty changes haven’t broken anything when the flag is off)
Sign in as above:
click on “enable_packs”
click “Delete”
type enable_packs in the “Are you sure” dialog and click ok
Criteria for completion
Background
The following sections have been identified as required for the PACKS implementation. These should be implemented in numerical order.
The text was updated successfully, but these errors were encountered: