Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simplecov and Code Climate Test Reporter #1145

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

cassianoblonski
Copy link
Contributor

@cassianoblonski cassianoblonski commented Oct 20, 2020

What github issue is this PR for, if any?

Resolves #1040

What changed, and why?

Simplecov version, after some time searching and looking at the errors and logs on Travis and checking the configuration for the test reporter I found a problem with simplecov 0.18+ and CodeClimate Test Reporter, some changes in simplecov 0.18 are not compatible with the actual CodeClimate Test Reporter, to make it work together I fixed the version of simplecov to 0.17.1, as stated on the issue codeclimate/test-reporter#418 CodeClimate core team is trying to work with simplecov to make 0.18 compatible with test reporter.

What is still needed?

I need someone with permission to edit the settings on this repo to add an env var called CC_TEST_REPORTER_ID with the CodeClimamte Test Reporter ID, that can be achieved similar to the example below:
image

Screenshots please :)

note that I tested the screenshots below with the current CC_TEST_REPORTER_ID on the travis.yml, we need to check if this ID is the correct one and add it to the repo env var on Repo Settings as stated above.

before:
image

after:
image

at the moment, waiting for the repo env var:
image

@github-actions github-actions bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 20, 2020
@cassianoblonski
Copy link
Contributor Author

@compwron can you edit the Repo Settings and add the env var listed on the description or ask someone with the permissions to do this.

Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@compwron compwron merged commit 63e0ea5 into rubyforgood:master Oct 21, 2020
@compwron
Copy link
Collaborator

Screen Shot 2020-10-21 at 12 23 42 AM

@compwron
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish test coverage data to codeclimate
2 participants