Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tables in topics #281

Merged
merged 3 commits into from
Nov 25, 2014
Merged

Remove tables in topics #281

merged 3 commits into from
Nov 25, 2014

Conversation

FrauBienenstich
Copy link
Member

closes #270 (or at least I hope so...)

@lislis
Copy link
Member

lislis commented Nov 24, 2014

Cool stuff!
One thing though: if you add a .col-xs-* to an element, it will keep this layout fo all bigger sizes since xs is active for the smallest screens.
That means that .col-xs-5 and .col-md-5 do the same thing. So if you don't want the layout to change you can omit the .col-md-*.
This is meant for applying different layouts when screens get bigger.
e.g.
'2 columns on small screens and 4 columns on medium screens' (with a total of 12 columns)
.col-xs-6.col-md-3
I that's understandable :)

@FrauBienenstich
Copy link
Member Author

cool, that IS understandable, will fix it 💩
I have no clue about feature specs, so maybe I will have someone explain to me tomorrow why exactly the build is failing...COZ I WILL BE AT THE P-GROUP!!11 (i mean, i see why it's failing, i am just not sure how to rewrite the spec)

@lislis
Copy link
Member

lislis commented Nov 24, 2014

+1

FrauBienenstich added a commit that referenced this pull request Nov 25, 2014
@FrauBienenstich FrauBienenstich merged commit 2526752 into master Nov 25, 2014
@FrauBienenstich FrauBienenstich deleted the remove_tables_in_topics branch November 25, 2014 19:14
@FrauBienenstich
Copy link
Member Author

errrmerrrgerrrrd

@FrauBienenstich
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of table markup in topics
2 participants