Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print out warnings when freeing. #28

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Don't print out warnings when freeing. #28

merged 1 commit into from
Aug 12, 2021

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Aug 7, 2021

There are some cases where you are using a zstream and don't care about the fact that it wasn't "closed". These warnings don't help at all, and create unnecessary output.

jeremyevans
jeremyevans approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I agree that the warnings don't add value, most other finalizers in Ruby don't print warning messages.

@ioquatix ioquatix merged commit 9050d89 into master Aug 12, 2021
@ioquatix ioquatix deleted the free-less-warnings branch August 12, 2021 07:10
@nobu nobu mentioned this pull request Aug 31, 2021
Merged
@nobu
Copy link
Member

nobu commented Aug 31, 2021

Zlib::GzipWriter still prints warnings.
Is this intentional?

zlib(finalizer): Zlib::GzipWriter object must be closed explicitly.
zlib(finalizer): the stream was freed prematurely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyevans jeremyevans jeremyevans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioquatix @nobu @jeremyevans