[language/block] Add two specs to check SyntaxError for block arguments #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but this should be in There is also some interesting behavior with this doubled p lambda {|_,_|_}.(1,2) # => 1But I would not consider that spec. |
|
(feel free to force push here or make another PR to move the spec to |
👌 Will do it later today, thank you Benoit 👍 |
|
@eregon Please take a look, thanks! |
eregon
added a commit
that referenced
this pull request
Jun 18, 2015
[Proc] Add two specs to check SyntaxError for block arguments
|
@JuanitoFatas Thanks for you contribution! |
|
Have a look at ea9f106. |
|
Much better! Thanks @eregon 👏 |
JuanitoFatas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two specs for block arguments syntax check.
Learned from here: thoughtbot/guides#335 (comment)