Fix github DSL docs to mention they use https protocol over git under the hood#5993
Merged
deivid-rodriguez merged 1 commit intoruby:masterfrom Oct 18, 2022
Merged
Conversation
This behavior change was done in Bundler 2.2.0. rubygems/bundler#7142 Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
deivid-rodriguez
changed the title
github DSL docs to mention they use https protocol over git under the hood
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 2, 2022
Fix `github` DSL docs to mention they use https protocol over git under the hood (cherry picked from commit c693e06)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 2, 2022
Fix `github` DSL docs to mention they use https protocol over git under the hood (cherry picked from commit c693e06)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
githuboption ingeminGemfilehas meant usinghttps://github.com(httpsprotocol) instead ofgit://github.com(gitprotocol), which was made in Bundler 2.2.0, but the document https://bundler.io/v2.3/man/gemfile.5.html#GITHUB is obsolete.What is your fix for the problem, implemented in this PR?
Fixes the document for
Gemfile(5)to align with the implementation on Bundler 2.2 or higher. This changes only Bundler 2.3 docs and backporting to docs for Bundler 2.2 is not expected as this is minor.Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com
Make sure the following tasks are checked