Fix TruffleRuby no longer able to install lockfiles generated with other implementations#5711
Merged
deivid-rodriguez merged 2 commits intomasterfrom Jul 13, 2022
Merged
Conversation
If the lockfile had been generated on another platform, we recently lost the ability to install the proper gems on TruffleRuby. The way I can think of to keep our current cleaner approach of using `force_ruby_platform` would be that TruffleRuby was reported as a special platform. But that would require further discussion, so for now I'm reverting the changes that caused this. In particular, reverts "Make sure truffleruby properly deals with old lockfiles" (the "lib" part of commit f971005) and "Better solution to support truffleruby platform handling" (the "lib" part of commit 6085de0).
deivid-rodriguez
changed the title
4 tasks
eregon
reviewed
Jul 13, 2022
deivid-rodriguez
added a commit
that referenced
this pull request
Jul 13, 2022
…sion Fix TruffleRuby no longer able to install lockfiles generated with other implementations (cherry picked from commit 3ac96cf)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Since #5495, TruffleRuby is no longer able to install lockfiles generated with other implementations. Specifically when they include platform specific gems, usually not compatible with TruffleRuby.
What is your fix for the problem, implemented in this PR?
I was no able to find a good solution that allows us to keep all the recent changes in the approach to supporting TruffleRuby by using
:force_ruby_platform. And I see no easy way of doing so. I think the only way to make this work cleanly would be to get TruffleRuby to report its own platform, so that we can act accordingly, and can trigger a fresh re-resolve if the lockfile was never bundled before with TruffleRuby before.Anyways, I'm not able to implement or make a proposal for the above right now, so for the moment I reverted our new approach to supporting TruffleRuby and restored what we were doing before.
Make sure the following tasks are checked