Skip to content

Improve bundler/setup performance again by not deduplicating intermediate results #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deivid-rodriguez merged 2 commits into from
May 16, 2022
Merged

Improve bundler/setup performance again by not deduplicating intermediate results #5533

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d00a9
Improve `bundler/setup` performance again
deivid-rodriguez May 13, 2022
2ea2523
Use `Array#concat` in `SpecSet#for` to save memory
deivid-rodriguez May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bundler/lib/bundler/spec_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def for(dependencies, check = false, match_current_platform = false)

specs_for_dep = spec_for_dependency(dep, match_current_platform)
if specs_for_dep.any?
match_current_platform ? specs += specs_for_dep : specs |= specs_for_dep
specs += specs_for_dep
Comment thread
deivid-rodriguez marked this conversation as resolved.
Outdated

specs_for_dep.first.dependencies.each do |d|
next if d.type == :development
Expand All @@ -40,6 +40,8 @@ def for(dependencies, check = false, match_current_platform = false)
specs << spec
end

specs.uniq! unless match_current_platform
Comment thread
deivid-rodriguez marked this conversation as resolved.

check ? true : specs
end

Expand Down