Remove hard errors when matching major bundler not found#5181
Merged
deivid-rodriguez merged 3 commits intomasterfrom Dec 22, 2021
Merged
Conversation
This was referenced Dec 19, 2021
Contributor
Author
|
I think this is a nice step to unblock a potential bundler 3 major release, and allows bundler 2.3 to properly handle lock files locked to bundler 1.17, for example, even if that version of bundler is not installed, thanks to our recent version switching feature. So since I didn't get feedback I'm going to merge it. |
simi
approved these changes
Dec 21, 2021
Contributor
Author
|
Thank you @simi!! |
Contributor
Author
|
I'll try fix CI and then merge this. |
Since we now have version auto-installation and switching inside rubygems, we can remove errors in major version mismatches from rubygems.
deivid-rodriguez
force-pushed
the
remove_hard_error_when_matching_major_bundler_not_found
branch
from
08ed0f6 to
41d62c7
Compare
deivid-rodriguez
deleted the
remove_hard_error_when_matching_major_bundler_not_found
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 22, 2021
…g_major_bundler_not_found Remove hard errors when matching major bundler not found (cherry picked from commit 459b12b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Since we will now have auto-installing and auto-switching to the
BUNDLED WITHversion in the lockfike, we can completely remove these hard error from RubyGems.What is your fix for the problem, implemented in this PR?
Remove all the code that we no longer need.
Fixes #2671.
Supersedes #2696.
Closes #2800.
Fixes #3275.
Fixes #3283.
Fixes #3334.
Make sure the following tasks are checked