Use a more limited number of threads when fetching in parallel from the Compact Index API #4670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently hardcoded 25 is too much and seems to cause some systems to even run out of memory. This also removes the only rubinius specific code in the repository. We don't really support rubinius so it doesn't make sense to keep those different branches.
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 21, 2021
Use a more limited number of threads when fetching in parallel from the Compact Index API (cherry picked from commit 54adf80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The currently hardcoded 25 is too much and seems to cause some systems to even run out of memory.
What is your fix for the problem, implemented in this PR?
I chose the use the number of available processors here rather than an arbitrary hardcoded number.
I would expect this to fix #4666 and fix #4353.
It also removes the only rubinius specific code in the repository. We don't really support rubinius so it doesn't make sense to keep those different code branches.
Make sure the following tasks are checked