Merged
Conversation
The `install_gems` helper was only used three times outside of `system_gems`, and these helpers were essentially doing the same thing. Besides that, there's another helper at `spec/support/rubygems_ext.rb` called `install_gems`, making things confusing and brittle.
simi
approved these changes
Jun 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a couple of improvements in bundler specs:
install_gemsandsystem_gemshelpers.realworld_system_gems, which is needed for the spec to be added in Fix RuboCop offenses #3740.Tasks:
I will abide by the code of conduct.