Delay removal of git shortcut DSL additions#3583
Merged
deivid-rodriguez merged 2 commits intomasterfrom May 12, 2020
Merged
Conversation
deivid-rodriguez
commented
May 1, 2020
bundler/lib/bundler/feature_flag.rb
Outdated
| settings_flag(:print_only_version_number) { bundler_3_mode? } | ||
| settings_flag(:setup_makes_kernel_gem_public) { !bundler_3_mode? } | ||
| settings_flag(:skip_default_git_sources) { bundler_3_mode? } | ||
| settings_flag(:skip_default_git_sources) { bundler_4_mode? } |
Contributor
Author
There was a problem hiding this comment.
In the first commit of the PR I delayed the deprecation, but I believe there's no use of maintaining code that never gets run by either end users or tests, so I would rather actually remove this code until we release bundler 3, and only then restore it. So in the second commit I did that.
deivid-rodriguez
force-pushed
the
delay_git_shortcuts_removal
branch
from
b0cf138 to
22b1388
Compare
We can restore it once we release bundler 3.
deivid-rodriguez
force-pushed
the
delay_git_shortcuts_removal
branch
from
22b1388 to
0f8e959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #3579.
We delayed the deprecation of git based DSL shortcuts in rubygems/bundler#7000, but didn't delay their removal.
This PR does that.
Tasks:
I will abide by the code of conduct.