Fix pre-release version comparison across versions with different non-canonical segments#2727
Closed
greysteil wants to merge 2 commits intoruby:masterfrom
greysteil:fix-prerelease-version-comparison
Closed
Fix pre-release version comparison across versions with different non-canonical segments#2727greysteil wants to merge 2 commits intoruby:masterfrom greysteil:fix-prerelease-version-comparison
greysteil wants to merge 2 commits intoruby:masterfrom
greysteil:fix-prerelease-version-comparison
Conversation
Contributor
|
@greysteil See #2651 😃 |
Contributor
Author
|
Ha! Make sense. I think the current situation is definitely a bug, and we should ship this as a bug fix. The case I put in the description of this PR isn't really defensible as a feature. I'll close here and add a 👍 to #2651. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, the following happens:
That is inconsistent. I propose that the second statement should be true. (Alternatively we could make the first statement false, but that is arguably a breaking change.)
Tasks:
I will abide by the code of conduct.