Revert downgrading bundler mismatches to a warning#2694
Merged
1 commit merged intomasterfrom Mar 23, 2019
Merged
Conversation
deivid-rodriguez
changed the title
Member
|
👌 We should unify the rubygems and bundler like rails/rails repository and use the master branches both. |
Contributor
Author
|
Yes. We definitely should... |
Contributor
Author
|
Maybe we can add a single job to test this for now like in here 36e3736. A bit of overhead but not too much. |
Contributor
Author
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 23, 2019
2694: Revert downgrading bundler mismatches to a warning r=deivid-rodriguez a=deivid-rodriguez This reverts commit dad8d25, reversing changes made to b4063c6. # Description: #2621 broke bundler's build. I'm going to investigate why but in the meantime I don't want to have a red master in bundler so I'm reverting this. I wonder if we should test rubygems against a vendored bundler that contains the code in bundler's master. Probably too much overhead 🤷♂️. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dad8d25, reversing changes made to b4063c6.
Description:
#2621 broke bundler's build. I'm going to investigate why but in the meantime I don't want to have a red master in bundler so I'm reverting this.
I wonder if we should test rubygems against a vendored bundler that contains the code in bundler's master. Probably too much overhead 🤷♂️.
Tasks:
I will abide by the code of conduct.