Merged
Conversation
Contributor
|
This is great @colby-swandale thanks! |
bronzdoc
approved these changes
Nov 19, 2018
Contributor
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2018
2478: Enable Style/MethodDefParentheses in Rubocop r=bronzdoc a=colby-swandale # Description: One of my biggest annoyances with the current style of Rubygems' codebase is the inconsistent use of parentheses on method definitions. Their use is very mixed and I want to set a single style (methods definitions *must* use parentheses) and enforce it with Rubocop. # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Colby Swandale <me@colby.fyi>
Build succeeded |
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Nov 19, 2018
2479: Enable Style/MultilineIfThen in Rubocop r=colby-swandale a=bronzdoc # Description: Similar to #2478 Remove trailing `then` keyword from `if` and `unless` statements I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 21, 2018
* Enable Style/MethodDefParentheses in Rubocop
ruby/rubygems#2478
* Enable Style/MultilineIfThen in Rubocop
ruby/rubygems#2479
* Fix required_ruby_version with prereleases and improve error message
ruby/rubygems#2344
* Fix bundler rubygems binstub not properly looking for bundler
ruby/rubygems#2426
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ioquatix
pushed a commit
to ioquatix/ruby
that referenced
this pull request
Nov 22, 2018
* Enable Style/MethodDefParentheses in Rubocop
ruby/rubygems#2478
* Enable Style/MultilineIfThen in Rubocop
ruby/rubygems#2479
* Fix required_ruby_version with prereleases and improve error message
ruby/rubygems#2344
* Fix bundler rubygems binstub not properly looking for bundler
ruby/rubygems#2426
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
bannable
pushed a commit
to bannable/ruby
that referenced
this pull request
Dec 10, 2018
* Enable Style/MethodDefParentheses in Rubocop
ruby/rubygems#2478
* Enable Style/MultilineIfThen in Rubocop
ruby/rubygems#2479
* Fix required_ruby_version with prereleases and improve error message
ruby/rubygems#2344
* Fix bundler rubygems binstub not properly looking for bundler
ruby/rubygems#2426
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt
pushed a commit
to rubygems/rubygems-server
that referenced
this pull request
Sep 24, 2021
2479: Enable Style/MultilineIfThen in Rubocop r=colby-swandale a=bronzdoc # Description: Similar to ruby/rubygems#2478 Remove trailing `then` keyword from `if` and `unless` statements I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
pombredanne
pushed a commit
to aboutcode-org/univers
that referenced
this pull request
Dec 7, 2021
2479: Enable Style/MultilineIfThen in Rubocop r=colby-swandale a=bronzdoc # Description: Similar to ruby/rubygems#2478 Remove trailing `then` keyword from `if` and `unless` statements I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
One of my biggest annoyances with the current style of Rubygems' codebase is the inconsistent use of parentheses on method definitions. Their use is very mixed and I want to set a single style (methods definitions must use parentheses) and enforce it with Rubocop.
Tasks:
I will abide by the code of conduct.