Remove semver gem build warning#2351
Merged
bundlerbot merged 1 commit intoruby:masterfrom Jul 18, 2018
Merged
Conversation
It's too brittle.
4 tasks
segiddins
approved these changes
Jul 11, 2018
Contributor
segiddins
left a comment
segiddins
left a comment
There was a problem hiding this comment.
Seems like a very reasonable change to me 👍
Contributor
|
@bundlerbot r+ |
Contributor
|
📌 Commit ada55f0 has been approved by |
Contributor
bundlerbot
added a commit
that referenced
this pull request
Jul 18, 2018
Remove semver gem build warning # Description: This is an alternative to #2323. I think this warning is too brittle at the moment because `rubygems` has no way of knowing if a dependency is semantically versioned. If a dependency is not semantically versioned, I don't see the problem with using something like `~> 1.2.3` so suggesting a constraint that does the same thing in a more complicated way just because it does not warn seems no good. In the future maybe rubygems could provide a `spec.versioning_policy =` accessor where gems can inform of their own versioning (`:semver`, or others) but currently I think this warning should just go. ______________ # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Contributor
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is an alternative to #2323.
I think this warning is too brittle at the moment because
rubygemshas no way of knowing if a dependency is semantically versioned. If a dependency is not semantically versioned, I don't see the problem with using something like~> 1.2.3so suggesting a constraint that does the same thing in a more complicated way just because it does not warn seems no good.In the future maybe rubygems could provide a
spec.versioning_policy =accessor where gems can inform of their own versioning (:semver, or others) but currently I think this warning should just go.Tasks:
I will abide by the code of conduct.