Add a note for the non-semantically versioned case#2242
Merged
bundlerbot merged 1 commit intoruby:masterfrom Mar 23, 2018
Merged
Add a note for the non-semantically versioned case#2242bundlerbot merged 1 commit intoruby:masterfrom
bundlerbot merged 1 commit intoruby:masterfrom
Conversation
Contributor
|
Thanks! @bundlerbot r+ |
Contributor
|
📌 Commit de025f8 has been approved by |
Contributor
bundlerbot
added a commit
that referenced
this pull request
Mar 23, 2018
…ronzdoc Add a note for the non-semantically versioned case # Description: Fixes #2228 by recommending another form of version specification when the overly strict dependency is not actually semantically versioned. ______________ # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Contributor
|
☀️ Test successful - status-travis |
4 tasks
bundlerbot
added a commit
that referenced
this pull request
Apr 24, 2018
Tweak warning recommendation # Description: In #2242 I introduced a recommendation to fix the semver warning in the case where the dependency is not semantically versioned. However, I think the recommendation was incorrect since, for example, `< 5.2` still allows `5.2.0.rc1`, whereas something like `~> 5.1.5` does not. I was bitten by this when I updated my dependencies according to the recommendation and the `rails-5.2.0.rc1` gem installed on my system was unintentionally activated. # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #2228 by recommending another form of version specification when the overly strict dependency is not actually semantically versioned.
Tasks:
I will abide by the code of conduct.