Fix metadata link key names#1896
Merged
Merged
Conversation
Contributor
|
👍 |
sonalkr132
force-pushed
the
fix-metadata-link-names
branch
from
0559115 to
01df511
Compare
segiddins
reviewed
Apr 18, 2017
| url_validation_regex = %r{\Ahttps?:\/\/([^\s:@]+:[^\s:@]*@)?[A-Za-z\d\-]+(\.[A-Za-z\d\-]+)+\.?(:\d{1,5})?([\/?]\S*)?\z} | ||
| link_keys = ["home", "code", "docs", "wiki", "mail", "bugs", "changelog"] | ||
| link_keys = %w( | ||
| homepage_uri |
Contributor
There was a problem hiding this comment.
please sort these so future diffs will be cleaner
segiddins
reviewed
Apr 18, 2017
| @m1 = quick_gem 'm', '1' do |s| | ||
| s.files = %w[lib/code.rb] | ||
| s.metadata = { "one" => "two", "home" => "https://example.com/user/repo" } | ||
| s.metadata = { "one" => "two", "homepage_uri" => "https://example.com/user/repo" } |
Contributor
There was a problem hiding this comment.
please also add a test that the un-prefixed keys aren't validated?
Contributor
Author
There was a problem hiding this comment.
I understand the need for test, as in if correct keys were not used links won't show up on rubygems.org.
It's hard to imagine such test. un-prefixed keys won't be invalid as metadata accepts any value for its keys.
Contributor
There was a problem hiding this comment.
we want to make sure that specifying a non-URI string for home is allowed
sonalkr132
force-pushed
the
fix-metadata-link-names
branch
from
01df511 to
6ad3087
Compare
sonalkr132
force-pushed
the
fix-metadata-link-names
branch
from
6ad3087 to
a86da1d
Compare
Contributor
Author
|
Updated. |
Contributor
|
Wonderful, thank you so much @sonalkr132 ! @homu r+ |
Contributor
|
📌 Commit a86da1d has been approved by |
Contributor
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Apr 19, 2017
Fix metadata link key names # Description: I had used incorrect names for metadata link keys. Related: rubygems/rubygems.org#1234 (comment) Good thing it wasn't released with 2.6.11. Is there anything I can do to make sure that my commits are in next release? I need to update guides. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I had used incorrect names for metadata link keys. Related: rubygems/rubygems.org#1234 (comment)
Good thing it wasn't released with 2.6.11. Is there anything I can do to make sure that my commits are in next release? I need to update guides.
Tasks:
I will abide by the code of conduct.