Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ruby_nonempty_memcpy to have C linkage #4429

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

xtkoba
Copy link
Contributor

@xtkoba xtkoba commented Apr 29, 2021

Fixes [Bug #17788]

Copy link
Member

@shyouhei shyouhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure seems unrelated.

@aliismayilov
Copy link

any chance this can be merged? The mentioned bug is blocking us from migrating from ruby 2 to 3.

@shyouhei shyouhei merged commit 29f6f79 into ruby:master Jul 13, 2021
@shyouhei
Copy link
Member

Merged! Thank you.

@xtkoba xtkoba deleted the pr-bug17788 branch August 16, 2021 05:28
@jwoodrow
Copy link

jwoodrow commented Nov 6, 2021

Hi 👋

Any news on when this will be released in a ruby version ? I see it was merged on the 13th of July and 3.0.2 was released the 7th of July.

We're having issues that apparently this seems to address but have no way of using it with ruby's docker images

@svoop
Copy link
Contributor

svoop commented Nov 6, 2021

Thanks for this fix, @xtkoba !!

@jwoodrow Same here, we're stuck on Ruby 2 as mini_racer which won't compile on the Ruby 3.0.2 Alpine Docker image. If no 3.0.3 is cut beforehand, the Xmas release of Ruby 3.1 should help.

@lloeki
Copy link
Contributor

lloeki commented Nov 6, 2021

I remember being able to work around this for some gems by using clang instead of gcc, something along the lines of:

apk update
apk add clang
env CC=clang CXX=clang++ gem install mini_racer

@jwoodrow
Copy link

jwoodrow commented Nov 6, 2021

I remember being able to work around this for some gems by using clang instead of gcc, something along the lines of:


apk update

apk add clang

env CC=clang CXX=clang++ gem install mini_racer

Hey @lloeki ! It just so happens that I'm having issues with one of the gems you publish (sq_mini_racer as a dependence of sqreen) in an ruby:3.0.1alpine docker container the gem refuses to build because of this error. That's why I'm hoping a new ruby release would come soon since I can't seem to fork the sq_mini_racer gem to monkeypatch it.

Any idea how I could fix this since the clang solution doesn't seem to work for sq_mini_racer ?

@shyouhei
Copy link
Member

shyouhei commented Nov 7, 2021

Hello. This pull request is merged. 3.1 (expected to happen next month) must include it. If you want this also be seen in 3.0.3 (maybe, no concrete plan yet), you might want to file a backport request at https://bugs.ruby-lang.org/issues/new . A backport request looks like for example https://bugs.ruby-lang.org/issues/18252 .

@svoop
Copy link
Contributor

svoop commented Nov 7, 2021

@shyouhei Thanks for the insights! Our project is under no pressure, so I can wait for Ruby 3.1, but maybe @jwoodrow would like to have a go filing a backport request.

@jwoodrow
Copy link

jwoodrow commented Nov 7, 2021

@shyouhei Thanks for the info, just like @svoop I have no immediate need for this fix I was asking if it was already planned because I'm trying to do some optimizations for a project's docker image and this would have helped but I can circumvent this somewhat. So I won't be filing for a backport neither

@shyouhei
Copy link
Member

JFTY ruby 3.1 preview 1 includes this fix.

@tisba
Copy link

tisba commented Mar 5, 2022

For reference, in case somebody stumbles across this PR: There is a backport request for Ruby 3.0.x: https://bugs.ruby-lang.org/issues/18574

@lloeki
Copy link
Contributor

lloeki commented Mar 7, 2022

[Bug #18574] backport request was changed to closed 25 days ago, not sure if it's been backported (doesn't look like so from that branch, which does not reference [Bug #17788] nor #4429)

@tisba
Copy link

tisba commented Apr 3, 2022

FYI: It has been backported to ruby_3_0 in 2bb5fa4.

@Startouf
Copy link

Startouf commented Mar 2, 2023

I confirm that the bug existed in ruby 3.0.3 and is fixed on ruby 3.0.5. See brianmario/charlock_holmes#166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants