-
Notifications
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ReDoS by using repeated space characters inside `<!DOCTYPE name […
…<!ATTLIST>]>` (#176) Fix performance by removing unnecessary spaces. This is occurred in Ruby 3.1 or earlier.
- Loading branch information
1 parent
1cc1d9a
commit 1f1e6e9
Showing
2 changed files
with
18 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
require "test/unit" | ||
require "core_assertions" | ||
|
||
require "rexml/document" | ||
|
||
module REXMLTests | ||
class TestParseAttlist < Test::Unit::TestCase | ||
include Test::Unit::CoreAssertions | ||
|
||
def test_gt_linear_performance | ||
seq = [10000, 50000, 100000, 150000, 200000] | ||
assert_linear_performance(seq, rehearsal: 10) do |n| | ||
REXML::Document.new('<!DOCTYPE schema SYSTEM "foo.dtd" [<!ATTLIST ' + " " * n + ' root v CDATA #FIXED "test">]>') | ||
end | ||
end | ||
end | ||
end |