Remove terminfo.rb #769
Merged
Remove terminfo.rb #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nment. Reline works perfectly in most major terminal emulators without terminfo. In minor/old terminal emulator, we used to get key bindings from terminfo, but I think it is not used so much.
|
If we should extract this feature to like |
|
Having an optional dependency for a small group of users to adapt reline to their keybindings seems like a great solution. |
|
I think supporting terminfo inside Reline is more maintainable compared to supporting reline-terminfo gem |
st0012
approved these changes
Nov 13, 2024
ima1zumi
approved these changes
Nov 14, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 14, 2024
non-windows environment. (ruby/reline#769) Reline works perfectly in most major terminal emulators without terminfo. In minor/old terminal emulator, we used to get key bindings from terminfo, but I think it is not used so much. ruby/reline@3ceba3bff7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reline uses fiddle to load terminfo from libncurses.
Fiddle and libncurses are not available in some environment. Fiddle will be removed from default gems, so we will going to have more problem loading terminfo.
When Reline is used in most terminal emulator, terminfo has no effect. Reducing dependency is better.
Impact of removing terminfo.rb
It depends on the statistics of environment variable TERM used in real world.
I searched with "export TERM=" in github.
(This does not reflect actual terminal emulator used in real world, but I don't have idea to figure it out)
Out of 46.8k files, these TERM values (146 files) has a different key bindings from key bindings that Reline registers without terminfo.
Detailed result is here https://gist.github.com/tompng/2e19e75234f61e250bafd4c50ec5b7be
Checking with
infocmpcommand,sun,vt52andd210-dgdoes not havecuucudhpacapability that Reline uses. Reline might not work even with terminfo, so exclude them.cons25have differenthpavalue,machandxtermcdoes not havehpa. Perhaps Reline does not work in these environments too.In
TERM=aaa-60|aixterm|cons25|mach|qansi|xtermc, End, PageUP, PageDown, Delete(Not Backspace) won't work. But some keyboard (example: Macbook) does not have these keys in the first place.- - - \e[P\e[146q \e[150q \e[154q \e[P\e[F \e[I \e[G \u007F\e[Y \e[V \e[U \e[9\e[Y \e[V \e[U \e[P\e[Y \e[V \e[U -Other tools
Readline uses terminfo
zshuses terminfo.nodeandipythondoes not seem to use terminfo