Remove unused things from reline/unicode.rb #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase it? |
tompng
force-pushed
the
unicode_remove_unused
branch
from
65e7940
to
b8829c0
Compare
|
Thanks! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 10, 2024
(ruby/reline#759) * Remove garbage(nil) from Reline::Unicode.split_by_width result * Remove unused width from Reline::Unicode vi_ ed_ em_ method return value * Remove unused height from Unicode.split_by_width return value * Rename split_by_width to split_line_by_width and add legacy split_by_width for IRB ruby/reline@f32446ebc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused value from Reline::Unicode method's return value
split_by_width
split_line_by_width
IRB uses legacy split_by_width. We need to rename it for refactored implementation and add a legacy split_by_width back.
em_ vi_ methods
Reline::Unicode.em_forward_wordReline::Unicode.vi_big_forward_wordand more methods returned[byte_size, visible_width]butvisible_widthpart is unused.These method didn't had tests. Tests are added to ensure this change didn't break anything.