Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FD leaks #752

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix FD leaks #752

merged 1 commit into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. Fix FD leaks

    `PTY.spawn` with a block detaches the spawned process and leaves it
    running in background even after exiting the given block.  It is the
    responsibility of the caller to clean up the yielded IOs and PID.
    
    https://github.com/ruby/ruby/actions/runs/11148759246/job/30986064044#step:13:950
    ```
    Leaked file descriptor: Reline::Test#test_tty_amibuous_width: 9 : #<File:/dev/pts/0>
    Leaked file descriptor: Reline::Test#test_tty_amibuous_width: 10 : #<File:/dev/pts/0>
    Leaked file descriptor: Reline::Test#test_tty_amibuous_width: 11 : #<File:/dev/pts/1>
    Leaked file descriptor: Reline::Test#test_tty_amibuous_width: 12 : #<File:/dev/pts/1>
    Leaked file descriptor: Reline::Test#test_tty_amibuous_width: 13 : #<File:/dev/pts/2>
    Leaked file descriptor: Reline::Test#test_tty_amibuous_width: 14 : #<File:/dev/pts/2>
    ```
    nobu committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ac33c23 View commit details
    Browse the repository at this point in the history