searcher.js: handle missing RegExp.escape #1442
Merged
+5
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That API is more recent than I expected, so there is still a small minority of browsers that may be missing it. But this escaping is only needed when the search context special chars, which too is a minority of searches. Given that, I think it's better to just not escape if support is missing.
|
🚀 Preview deployment available at: https://a240a3af.rdoc-6cd.pages.dev (commit: 150c231) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That API is more recent than I expected, so there is still a small minority of browsers that may be missing it.
But this escaping is only needed when the search context special chars, which too is a minority of searches.
Given that, I think it's better to just not escape if support is missing.
cc @st0012