Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead or unnecessary methods/attributes #1315

Merged
merged 10 commits into from
Mar 16, 2025
Merged

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Mar 16, 2025

2 types of targets in this PR:

  • Completely unused methods (outside of tests, ofc)
  • Single-used or unnecessary methods. Like:
  def each_constant # :yields: constant
    @constants.each {|c| yield c}
  end

Copy link

cloudflare-workers-and-pages bot commented Mar 16, 2025

Deploying rdoc with  Cloudflare Pages  Cloudflare Pages

Latest commit: acb2e2b
Status: ✅  Deploy successful!
Preview URL: https://1cb6e909.rdoc-6cd.pages.dev
Branch Preview URL: https://remove-dead-methods.rdoc-6cd.pages.dev

View logs

@c1.each_extend do |extend| extend.module end # cache extended modules

@m1_m2.document_self = nil
assert @m1_m2.remove_from_documentation?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These same test assertions actually appear in other tests like test_update_includes_with_colons as well. So we don't need to keep them here either.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@st0012 st0012 force-pushed the remove-dead-methods branch from 696f5dd to d1c838c Compare March 16, 2025 12:09
@st0012 st0012 force-pushed the remove-dead-methods branch from d1c838c to acb2e2b Compare March 16, 2025 12:28
@st0012 st0012 merged commit d659484 into master Mar 16, 2025
60 checks passed
@st0012 st0012 deleted the remove-dead-methods branch March 16, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants