Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby-core workflow to just generate documentation #1278

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jan 15, 2025

Since RDoc is now a bundled gem, we don't need to run test with Ruby core with it commit by commit. But it'd still be beneficial to generate documentation with the current RDoc commit and the Ruby master branch.

So this PR updates the Ruby core workflow to just do that.

@st0012 st0012 force-pushed the update-ruby-core-workflow branch 4 times, most recently from 4f7ef7c to 79cc062 Compare January 15, 2025 23:03
@st0012 st0012 force-pushed the update-ruby-core-workflow branch 6 times, most recently from 248fa8b to 0208cb0 Compare January 21, 2025 00:35
@st0012
Copy link
Member Author

st0012 commented Jan 21, 2025

@kou Ok I found a way to make it work:

  1. We don't need to build the full Ruby since we're not running tests against it anymore.
  2. Because Ruby extracts bundled gems from the /gems folder, we can move build RDoc ourselves and move the .gem file there.
  3. When running make html, it'd try to extract gems from /gems, which will then use the RDoc that just got built.

Unverified

The email in this signature doesn’t match the committer email.
Since RDoc is now a bundled gem, we don't need to run test with Ruby core
with it commit by commit. But it'd still be beneficial to generate
documentation with the current RDoc commit and the Ruby master branch.

So this PR updates the Ruby core workflow to just do that.
@st0012 st0012 force-pushed the update-ruby-core-workflow branch from 0208cb0 to ebd680c Compare January 21, 2025 00:41
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@st0012 st0012 merged commit 1b16fe6 into master Jan 21, 2025
51 checks passed
@st0012 st0012 deleted the update-ruby-core-workflow branch January 21, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants