Move the responsibility of safe loading to Node #643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the responsibility of safely loading a YAML tree from an internal detail of
Psych.safe_load
intoPsych::Nodes::Node
.The advantage of this is that you can now more easily safely load trees that you're working on without replicating the safety constraints of
Psych.safe_load
. The delegation of responsibilities also now matches for safely and unsafely loading a tree.I opted for two choices to make the diff smaller:
Psych.safe_load
instead of moving it toPsych::Nodes::Node#to_safe_ruby
. The main reason I chose to do so is thatPsych.safe_load
is the most likely entry point into using Psych for most people, so having the documentation on that method makes sense.Psych::Nodes::Node
rather than duplicating them. The reason I chose to do this was to reduce the chance of two lists of arguments becoming unsynchronized. Additionally, since the behavior actually belongs toPsych::Nodes::Node
now, it's the only place that can have the defaults set for all use cases.