-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(visitor): allow to create custom object (instead of Hash) according to context #299
Open
kwatch
wants to merge
8
commits into
ruby:master
Choose a base branch
from
kwatch:topic_custom-class-visitor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 18, 2016
-
feat(psych): allow to generate custom Hash object
This is necessary to create custom object as mapping instead of Hash. For example, if you prefer `hashobj.key` instead of `hashobj['key']`: ## allows `h.foo` instead of `h['foo']` class MagicHash < Hash def method_missing(method, *args) return super unless args.empty? return self[method.to_s] end end ## override to generate MagicHash instead of Hash class MagicVisitor < Psych::Visitors::ToRuby def empty_mapping(o) MagicHash.new end end ## example to access `ydoc.foo` instead of `ydoc['foo']` input = <<'END' tables: - name: admin_users columns: - name: id type: int pkey: true END tree = Psych.parse(input) visitor = MagicVisitor.create ydoc = visitor.accept(tree) p ydoc.tables[0].columns[0].name #=> "name" p ydoc.tables[0].columns[0].type #=> "int"
Configuration menu - View commit details
-
Copy full SHA for 4213ebe - Browse repository at this point
Copy the full SHA 4213ebeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9061f6 - Browse repository at this point
Copy the full SHA c9061f6View commit details
Commits on Nov 19, 2016
-
feat(psych): add hook point for mapping key and value
This is necessary to generate custom object as mapping instead of Hash according to context. For example: TableObj = Struct.new('TableObj', 'name', 'columns') ColumnObj = Struct.new('ColumnObj', 'name', 'type', 'pkey') class CustomVisitor < Psych::Visitors::ToRuby def initialize(*args) super @key_path = [] # ex: [] -> ['tables'] -> ['tables', 'columns'] end def accept_key(k) # push keys key = super k @key_path << key return key end def accept_value(v) # pop keys value = super v @key_path.pop() return value end def empty_mapping(o) # generate custom object instead of Hash case @key_path.last when 'tables' ; return TableObj.new when 'columns' ; return ColumnObj.new else ; return super o end end end ## example to generate custom object according to context input = <<'END' tables: - name: admin_users columns: - name: id type: int pkey: true END tree = Psych.parse(input) visitor = CustomVisitor.create ydoc = visitor.accept(tree) p ydoc['tables'][0].class #=> Struct::TableObj p ydoc['tables'][0]['columns'][0].class #=> Struct::ColumnObj
Configuration menu - View commit details
-
Copy full SHA for 95eab41 - Browse repository at this point
Copy the full SHA 95eab41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 080fd60 - Browse repository at this point
Copy the full SHA 080fd60View commit details -
Configuration menu - View commit details
-
Copy full SHA for b14d98f - Browse repository at this point
Copy the full SHA b14d98fView commit details -
feat(psych): define 'Psych::Visitors::CustomClassVisitor' class
This new class allows user to generate custom object instead of Hash. See document of CustomClassVisitor class for details.
Configuration menu - View commit details
-
Copy full SHA for b5d3885 - Browse repository at this point
Copy the full SHA b5d3885View commit details -
Configuration menu - View commit details
-
Copy full SHA for b81d44e - Browse repository at this point
Copy the full SHA b81d44eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34883b8 - Browse repository at this point
Copy the full SHA 34883b8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.