Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double quotes (2) #324

Closed
knugie opened this issue Jul 20, 2017 · 0 comments
Closed

Double quotes (2) #324

knugie opened this issue Jul 20, 2017 · 0 comments

Comments

@knugie
Copy link
Contributor

knugie commented Jul 20, 2017 •
edited
Loading

When emitting YAML using Psych, strings that have a key-value pair where the value contains a colon and a single quote, Psych escapes the single quote with another single quote, relates to #157.

I'd expect
Psych.dump(key: "me: I don't think so")
to return
"---\n:key: \"me: I don't think so\"\n"
It actually returns
"---\n:key: 'me: I don''t think so'\n"

This is not a huge issue but confuses people.
knugie pushed a commit to knugie/psych that referenced this issue Jul 21, 2017
@wteuber
Use double quotes for stings that contain single quotes only
f5e33f1 
Fixes ruby#324
knugie pushed a commit to knugie/psych that referenced this issue Jul 21, 2017
@wteuber
Use double quotes for stings that contain single quotes only
107fa2b 
Fixes ruby#324
knugie pushed a commit to knugie/psych that referenced this issue Jul 21, 2017
@wteuber
Double quote stings that contain single quotes only
803de61 
Fixes ruby#324
@knugie knugie mentioned this issue Jul 21, 2017
Merged
@hsbt hsbt closed this as completed in #325 Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knugie